Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[L1T] Backport: all modules switched to lower case and l1t #39251

Closed
wants to merge 6 commits into from
Closed

[L1T] Backport: all modules switched to lower case and l1t #39251

wants to merge 6 commits into from

Conversation

cecilecaillol
Copy link
Contributor

PR description:

Addressing item 1 of #39194: change L1 modules to start with l1t
Also addressing item 2 of the same issue: Fix hltTriggerSummaryAOD
Also addressing item 5 of the same issue: Verify the PSet cutset in L1TrackSelectionProducerExtended

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #39244

ccaillol added 6 commits August 30, 2022 16:42
lower case l1 modules
6f4b6e0 
(cherry picked from commit d9a27dd)
L1 module lower case in L1 packages
a41d7ee 
(cherry picked from commit 184dc2e)
l1t modules lower case
118b1a3 
(cherry picked from commit 9a9f1f3)
upper case Tasks, switch l1ct to l1t
fb952d7 
(cherry picked from commit cb38413)
Martins and Marinos comments
5e0ff75 
(cherry picked from commit d6921bd)
further renaming
ae056a1 
(cherry picked from commit c311777)
@cmsbuild cmsbuild added this to the CMSSW_12_5_X milestone Aug 30, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 30, 2022 •
edited
Loading

A new Pull Request was created by @cecilecaillol for CMSSW_12_5_X.

It involves the following packages:

  • DQMOffline/L1Trigger (dqm, l1)
  • HLTrigger/Configuration (hlt)
  • L1Trigger/Configuration (l1)
  • L1Trigger/L1CaloTrigger (upgrade, l1)
  • L1Trigger/L1TTrackMatch (upgrade, l1)
  • L1Trigger/Phase2L1GMT (l1)
  • L1Trigger/Phase2L1ParticleFlow (upgrade, l1)
  • L1Trigger/Phase2L1Taus (l1)
  • L1Trigger/VertexFinder (l1)

@Martin-Grunewald, @missirol, @epalencia, @emanueleusai, @ahmad3213, @cecilecaillol, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @pmandrik, @micsucmed, @rekovic, @rvenditti can you please review it and eventually sign? Thanks.
@silviodonato, @Martin-Grunewald, @missirol, @trtomei, @beaucero, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cecilecaillol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f07eb6/27202/summary.html
COMMIT: ae056a1
CMSSW: CMSSW_12_5_X_2022-08-30-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39251/27202/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 21 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3695708
  • DQMHistoTests: Total failures: 90
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3695596
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

backport of #39244

@cecilecaillol
Copy link
Contributor Author

Closing, new PR #39354 includes all the followups on the original PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport dqm-pending hlt-pending l1-pending orp-pending pending-signatures tests-approved upgrade-pending
Projects
None yet
Milestone
CMSSW_12_5_X
Development

Successfully merging this pull request may close these issues.
3 participants
@cecilecaillol @cmsbuild @perrotta